Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pycodestyle E115 and activate this check in the linter #39340

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

fchapoton
Copy link
Contributor

This is fixing

E115 expected an indented block (comment)

in src/sage ; and adding this check to the pycodestyle-minimal linter

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, LGTM.

Copy link

Documentation preview for this PR (built with commit c01c422; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 20, 2025
… linter

    
This is fixing

E115 expected an indented block (comment)

in src/sage ; and adding this check to the pycodestyle-minimal linter

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39340
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 23, 2025
… linter

    
This is fixing

E115 expected an indented block (comment)

in src/sage ; and adding this check to the pycodestyle-minimal linter

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39340
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 25, 2025
… linter

    
This is fixing

E115 expected an indented block (comment)

in src/sage ; and adding this check to the pycodestyle-minimal linter

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39340
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit dc00a5b into sagemath:develop Jan 27, 2025
21 of 23 checks passed
@fchapoton fchapoton deleted the fix_E115 branch January 27, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants